feat(value): create and impl ToJson trait #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn to_json(&self) -> Value { | ||
| to_value(&self) | ||
| } | ||
| } |
There was a problem hiding this comment.
It looks like there isn't a trailing newline at the end of the file. Could you add one?
|
This seems reasonable to me. r=erickt with my comment addressed. |
|
testing whether I have homu access. The travis failure is due to clippy @homu r+ |
homu
added a commit
that referenced
this pull request
May 13, 2016
feat(value): create and impl ToJson trait Refs #62 What do you think? Tests fail on `nightly`, but this seems unrelated.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #62
What do you think? Tests fail on
nightly, but this seems unrelated.